Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to 0.52 #7261

Draft
wants to merge 70 commits into
base: main
Choose a base branch
from
Draft

chore: update to 0.52 #7261

wants to merge 70 commits into from

Conversation

tac0turtle
Copy link
Member

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@tac0turtle tac0turtle changed the title chore: update to 0.52 (1/n) chore: update to 0.52 Sep 8, 2024
}

// allow the following addresses to receive funds
delete(modAccAddrs, authtypes.NewModuleAddress(govtypes.ModuleName).String())
delete(modAccAddrs, authtypes.NewModuleAddress(ibcmock.ModuleName).String())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just dropping a note here. We also need to delete ibc mock module address from blocked addresses (for usage in tests, was causing some failures)

Will change on other branch

testing/chain.go Outdated
@@ -388,7 +396,7 @@ func (chain *TestChain) SendMsgs(msgs ...sdk.Msg) (*abci.ExecTxResult, error) {
txResult := resp.TxResults[0]

if txResult.Code != 0 {
return txResult, fmt.Errorf("%s/%d: %q", txResult.Codespace, txResult.Code, txResult.Log)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to revert this. It rugs some tests.

Any reason to remove log here?

damiannolan and others added 11 commits November 21, 2024 16:25
* feat: adding runtime Environment

* chore: run make lint-fix

* chore: remove duplicate import

* chore: rm duplicate import

* chore: migrate to env KVStoreService in icacontroller

* chore: fix duplicate import

* chore: rm kv store service

* chore: refactor events to use environment

* chore: make lint-fix

* chore: make tidy-all

* chore: rm msg service router from icacontroller

* fix: remove 32 bit arm arch from callbacks ci builds

* test: try cache false for callbacks linter

* chore: pin to updated interchaintest fork

* chore: revert relayer count to 10

* chore: continued work on upgrading e2e tests to 0.52

* chore: transfer e2e passing

* chore: fix upgrade build errors

* chore: bump interchaintest

* chore: update  sample config

* chore: reconfigure protoany to use gogoproto any in favour of codec types

* chore: tidy imports in e2e

* fix: address failure in module safe query ica e2e test

* bump golangci version to 1.60

* lint: remove duplicate import

* chore: use gogoprotoany in favour of codec types any. rm ProtoCodecMarshaler for Codec iface

* chore: bump go version in Dockerfile

* chore: add todo

* lint: fix unnecessary cast

* deps: upgrade sdk to head of release/v0.52.x, upgrade store to latest main

* deps: bump to head of release/v0.52

* fix: add unit test to reproduce e2e test failure for ScheduleIBCUpgrade, update code to expect tendermint client temporarily

* fix: error in tests

* chore: address comments from pr

---------

Co-authored-by: chatton <[email protected]>
Co-authored-by: Nikolas De Giorgis <[email protected]>
…sts now use annoations for compatibility checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EPIC: Olympus Upgrade (SDk 0.52)
5 participants